[PATCH] D65141: [DivergenceAnalysis] Add methods for querying divergence at use

[Jay Foad via Phabricator via llvm-commits]

foad updated this revision to Diff 211462.
foad added a comment.
Herald added a subscriber: jfb.

Address review comments.

Rename the new methods to make it clear that they take a Use. Otherwise,
since there's an implicit conversion from Use to Value*, it's too hard
to be sure which overload you are calling.

Fix an egregious typo in LegacyDivergenceAnalysis::isDivergentUse.

Add a test for the atomic optimizer usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65141/new/

https://reviews.llvm.org/D65141

Files:
  llvm/include/llvm/Analysis/DivergenceAnalysis.h
  llvm/include/llvm/Analysis/LegacyDivergenceAnalysis.h
  llvm/lib/Analysis/DivergenceAnalysis.cpp
  llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp
  llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp
  llvm/test/CodeGen/AMDGPU/divergence-at-use.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65141.211462.patch
Type: text/x-patch
Size: 9451 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190724/6a424a2b/attachment.bin>