[PATCH] D65040: [llvm-objcopy] Add support for --add-section for COFF

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/add-section.test:29
+
+# CHECK-ERR2: llvm-objcopy{{(.exe)?}}: error:{{.+}} bad format for --add-section
+
----------------
Use the FileCheck -D option here too instead of `{{.+}}`


================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:189
+
+    if (SecName.empty() || FileName.empty())
+      return createStringError(llvm::errc::invalid_argument,
----------------
Does COFF allow for empty section names? If it does, you need to distinguish the case where there is no '=' at all in the parameter from it producing an empty string, i.e. "--add-sections==foo.txt" might be allowable if COFF allows empty section names (but not "--add-section=foo.txt".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65040/new/

https://reviews.llvm.org/D65040