[PATCH] D64903: [ELF] Pad the last page of last PF_X PT_LOAD with traps when -z separate-code is specified

Wed Jul 24 02:48:26 PDT 2019

peter.smith added a comment.

In D64903#1598435 <https://reviews.llvm.org/D64903#1598435>, @MaskRay wrote:

> Ping :)

I'm happy with the change to introduce the option and its effects. I'm not sure we have consensus on what the default should be for the option though. Today I have a weak preference for no separate code for Arm and AArch64, but I'd be happy with a conservative approach of keeping the existing --separate-code until there becomes a relatively convenient to make platform/distro specific decisions as ultimately that is where the decision should be made. The separate code default would also lower the amount of tests that would need to be updated for D64906 <https://reviews.llvm.org/D64906> and D64930 <https://reviews.llvm.org/D64930> making them easier to review and less of a risky change.

I think that there is a case for build-time defaults in LLD as there is not always a clang driver for the specific platform or LLD might be invoked by GCC. I think D56650 <https://reviews.llvm.org/D56650> is substantially more of a change from changing defaults of existing command line options as no decision making logic has to change.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64903/new/

https://reviews.llvm.org/D64903