[PATCH] D65175: [ARM] Transform compare of masked value to shift on Thumb1.

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 24 01:56:42 PDT 2019


ostannard added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:4065
+  // 1. C2 fits into the immediate field of a cmp.
+  // 2. C1 is 255 or 65535, so we can use "uxtb" or "uxth".
+  if (Subtarget->isThumb1Only() && LHS->getOpcode() == ISD::AND &&
----------------
I don't see any code implementing this case. Instead, there is a check that `Mask > 65535`, but this looks like it should still be profitable for masks between 255 and 65535.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65175/new/

https://reviews.llvm.org/D65175





More information about the llvm-commits mailing list