[PATCH] D64969: [llvm-objdump][NFC] Make the PrettyPrinter::printInst() output buffered

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 23:15:35 PDT 2019


seiya added a comment.

In D64969#1598506 <https://reviews.llvm.org/D64969#1598506>, @MaskRay wrote:

> Apologize I added formatted_raw_ostream and I didn't read its ctor carefully...
>
> > Benchmark #2: ./bin/llvm-objdump -d ./bin/llvm-objcopy
> > 
> >   Time (mean ± σ):     386.4 ms ±  13.0 ms    [User: 376.6 ms, System: 6.1 ms]
> >   Range (min … max):   366.1 ms … 407.0 ms    10 runs
>
> Please remember updating the description before you commit. The benchmark has been updated.


Don't apologize! This was a good opportunity for me to work on the performance issue and was just interesting :D


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64969/new/

https://reviews.llvm.org/D64969





More information about the llvm-commits mailing list