[PATCH] D65140: [yaml2obj] - Allow custom fields for the SHT_UNDEF sections.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/yaml2obj/elf-custom-null-section.yaml:127
   - Type: SHT_PROGBITS
-    Name: .foo
+    Name: 'foo'
 
----------------
Is there a reason for the `.foo` -> `'foo'` change?

`SHT_PROGBITS` should be aligned


================
Comment at: tools/yaml2obj/yaml2elf.cpp:966
     StringRef Name = Doc.Sections[I]->Name;
+    if (Name.empty())
+      continue;
----------------
What happens if there is non-SHN_UNDEF section with an empty name?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65140/new/

https://reviews.llvm.org/D65140