[PATCH] D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 23 15:37:02 PDT 2019
alexshap added a comment.
the code looks good to me, but we need tests. I'd add simple tests which take YAML (similarly to how the existing tests work), generate MachO (using yaml2obj), copy it using llvm-objcopy,
dump the results (using llvm-readobj and obj2yamal) and verify that the output is what we expect. Plus those tools will parse the binary generated by llvm-objcopy thus they will verify (to some extent) that we have built a valid MachO object file.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63395/new/
https://reviews.llvm.org/D63395
More information about the llvm-commits
mailing list