[PATCH] D64866: [PredicateInfo] Replace pointer comparisons with deterministic compares.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/PredicateInfo.cpp:151
+    bool isADef = A.Def;
+    bool isAU = A.U;
+    bool isBDef = B.Def;
----------------
Isn't `isAU` always equal to `!isADef`?


================
Comment at: llvm/lib/Transforms/Utils/PredicateInfo.cpp:198
+    unsigned AIn = DomADest->getDFSNumIn();
+    unsigned AOut = DomADest->getDFSNumOut();
+    unsigned BIn = DomBDest->getDFSNumIn();
----------------
Do you really need to compare AOut?  getDFSNumIn() should be unique for every domtree node.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64866/new/

https://reviews.llvm.org/D64866