[PATCH] D65163: Fix occasional hangs of VSCode testcases

Jan Kratochvil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 13:44:50 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL366850: [lldb] Fix occasional hangs of VSCode testcases (authored by jankratochvil, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D65163?vs=211345&id=211353#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65163/new/

https://reviews.llvm.org/D65163

Files:
  lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py


Index: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
===================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
+++ lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
@@ -498,13 +498,7 @@
             'arguments': args_dict
         }
         response = self.send_recv(command_dict)
-        recv_packets = []
-        self.recv_condition.acquire()
-        for event in self.recv_packets:
-            if event['event'] != 'stopped':
-                recv_packets.append(event)
-        self.recv_packets = recv_packets
-        self.recv_condition.release()
+        # Caller must still call wait_for_stopped.
         return response
 
     def request_disconnect(self, terminateDebuggee=None):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65163.211353.patch
Type: text/x-patch
Size: 825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190723/e887e01b/attachment.bin>


More information about the llvm-commits mailing list