[PATCH] D65095: ld.lld: Demangle symbols from archives in diagnostics

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 11:40:41 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/Symbols.h:26
+std::string toString(coff::Symbol &b);
+std::string toCOFFString(const coff::Archive::Symbol &b);
+
----------------
Can you leave a comment saying that we want two different stringize functions for ELF and COFF, so the function is named toCOFFString?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65095/new/

https://reviews.llvm.org/D65095





More information about the llvm-commits mailing list