[PATCH] D60388: FileCheck [8/12]: Define numeric var from expr

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

A couple of minor things, otherwise LGTM.



================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:648
 Important note: In its current implementation, an expression cannot use a
-numeric variable defined on the same line.
+numeric variable with a non-empty expression constraint defined on the same
+line.
----------------
constraint?


================
Comment at: llvm/include/llvm/Support/FileCheck.h:114
+  /// the value of the variable is given by evaluating \p ExpressionAST.
+  /// Otherwise, it is set from a value in the input.
   FileCheckNumericVariable(StringRef Name,
----------------
"it is set from a value in the input" ?  This is not a statement about what the ctor does, it sounds like an expectation.
"Otherwise, it should be set later from a value in the input." ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60388/new/

https://reviews.llvm.org/D60388