[PATCH] D65070: [LLVM-C][OCaml] Add a fast linker binding

[Robert Widmann via Phabricator via llvm-commits]

CodaFi requested changes to this revision.
CodaFi added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/llvm-c/Linker.h:47
+ */
+LLVMBool LLVMLinkInModule(LLVMLinkerCtx Dest, LLVMModuleRef Src);
+
----------------
Can you document the lifetime of the linked module?


================
Comment at: lib/Linker/LinkModules.cpp:617
+  std::unique_ptr<Module> M(unwrap(Src));
+  return L->linkInModule(std::move(M), Linker::Flags::None, {});
+}
----------------
Can you expose these two defaulted arguments in the bindings as well?  


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65070/new/

https://reviews.llvm.org/D65070