[PATCH] D65143: [InstCombine] Fold '(-1 u/ %x) u< %y' to '@llvm.umul.with.overflow' + overflow bit extraction

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 08:48:14 PDT 2019


xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3363
+  } else
+    return nullptr;
+
----------------
lebedev.ri wrote:
> xbolva00 wrote:
> > Early return maybe better?
> Then the diff in the very next patch (D65144) will have to re-indent, i wonder if this is more readable as-is..
Oh yea, +1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65143/new/

https://reviews.llvm.org/D65143





More information about the llvm-commits mailing list