[PATCH] D65121: [FileCheck][lit] Make FILECHECK_OPTS useful for their test suites

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D65121#1597486 <https://reviews.llvm.org/D65121#1597486>, @probinson wrote:

> The lit part seems like a good thing.  It's unfortunate that lit/test/lit.cfg needs to know about FileCheck environment variables, but them's the breaks.


If this issue were present in more test suites, I'd be tempted to extend FileCheck with a command-line option to encapsulate this use case in some manner.  As things are, that doesn't seem worth the trouble to me, but maybe others feel differently.

> That bit should be its own patch, regardless of how we decide to handle FileCheck itself.

Sure, I'll separate out the lit change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65121/new/

https://reviews.llvm.org/D65121