[PATCH] D65143: [InstCombine] Fold '(-1 u/ %x) u< %y' to '@llvm.umul.with.overflow' + overflow bit extraction
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 23 07:56:09 PDT 2019
lebedev.ri added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3363
+ } else
+ return nullptr;
+
----------------
xbolva00 wrote:
> Early return maybe better?
Then the diff in the very next patch (D65144) will have to re-indent, i wonder if this is more readable as-is..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65143/new/
https://reviews.llvm.org/D65143
More information about the llvm-commits
mailing list