[PATCH] D64616: [ARM][LowOverheadLoops] Fix branch target codegen

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 07:09:03 PDT 2019


SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:13139
+
+  assert((IsTrueIfZero(CC, Imm) || IsFalseIfZero(CC, Imm)) &&
+         "unsupported condition");
----------------
samparker wrote:
> SjoerdMeijer wrote:
> > I was wondering if we can return here; not sure though if that is better/more robust.
> At this point we know we have a loop intrinsic that we need to handle it.
ah yes, of course, silly me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64616/new/

https://reviews.llvm.org/D64616





More information about the llvm-commits mailing list