[compiler-rt] r366805 - [NFC][ASAN] Add brackets around not command

Lei Huang via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 23 06:10:29 PDT 2019


Author: lei
Date: Tue Jul 23 06:10:29 2019
New Revision: 366805

URL: http://llvm.org/viewvc/llvm-project?rev=366805&view=rev
Log:
[NFC][ASAN] Add brackets around not command

Under certain execution conditions, the `not` command binds to the command the
output is piped to rather than the command piping the output. In this case, that
flips the return code of the FileCheck invocation, causing a failure when
FileCheck succeeds.

Modified:
    compiler-rt/trunk/test/asan/TestCases/Linux/read_binary_name_regtest.c

Modified: compiler-rt/trunk/test/asan/TestCases/Linux/read_binary_name_regtest.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/read_binary_name_regtest.c?rev=366805&r1=366804&r2=366805&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Linux/read_binary_name_regtest.c (original)
+++ compiler-rt/trunk/test/asan/TestCases/Linux/read_binary_name_regtest.c Tue Jul 23 06:10:29 2019
@@ -2,7 +2,7 @@
 // the binary name because of sandbox restrictions.
 // This test uses seccomp-BPF to restrict the readlink() system call and makes
 // sure ASan is still able to
-// RUN: not ls /usr/include/linux/seccomp.h || ( %clang_asan %s -o %t && not %run %t 2>&1 | FileCheck %s )
+// RUN: not ls /usr/include/linux/seccomp.h || ( %clang_asan %s -o %t && ( not %run %t 2>&1 ) | FileCheck %s )
 // REQUIRES: shell
 // UNSUPPORTED: android
 




More information about the llvm-commits mailing list