[PATCH] D64557: Add llvm.loop.licm.disable metadata

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

@fhahn  @arsenm @hfinkel Has the motivation question been sufficiently addressed?



================
Comment at: test/Transforms/LICM/pragma-licm-disable.ll:5
+
+; RUN: opt < %s -S -basicaa -licm | FileCheck %s
+
----------------
By convention, the `RUN` lines are the first in the file, even before comments.


================
Comment at: test/Transforms/LICM/pragma-licm-disable.ll:29-37
+do.body.l2_crit_edge:                             ; preds = %do.body
+  %inval.pre = load i32*, i32** @in, align 8
+  br label %l2
+
+l1:                                               ; preds = %do.body
+  %v1 = load i64, i64* bitcast (i32** @in to i64*), align 8
+  store i64 %v1, i64* bitcast (i32** @out to i64*), align 8
----------------
Could you simplify the test? Remove branching within the loop, at most one PHI, one load (and maybe a store so the load result is not unused).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64557/new/

https://reviews.llvm.org/D64557