[PATCH] D65137: [GVN] Preserve loop related analysis/canonical forms.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Minor comments.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:2478
+      if (!DeadBlocks.count(P))
+        continue;
       for (BasicBlock::iterator II = B->begin(); isa<PHINode>(II); ++II) {
----------------
These changes, incl. the `isCriticalEdge` modifications above, seem unrelated to the loop info issue, are they?


================
Comment at: llvm/test/Transforms/GVN/preserve-analysis.ll:50
+  ret i32 %iv
+}
----------------
You should check that GVN did something as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65137/new/

https://reviews.llvm.org/D65137