[PATCH] D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 23 03:34:25 PDT 2019
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: test/tools/llvm-readobj/elf-file-types.test:88
+
+# RUN: yaml2obj %s --docnum=6 -o %t6
+# RUN: llvm-readobj -h %t6 | FileCheck %s --match-full-lines --check-prefix LLVM-LOPROC
----------------
jhenderson wrote:
> You should probably also test something in the ET_LOOS -> ET_HIOS range too.
Interesting that ELF.h doesn't define `ET_LOOS`/`ET_HIOS`:
```
// File types
enum {
ET_NONE = 0, // No file type
ET_REL = 1, // Relocatable file
ET_EXEC = 2, // Executable file
ET_DYN = 3, // Shared object file
ET_CORE = 4, // Core file
ET_LOPROC = 0xff00, // Beginning of processor-specific codes
ET_HIPROC = 0xffff // Processor-specific
};
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65068/new/
https://reviews.llvm.org/D65068
More information about the llvm-commits
mailing list