[PATCH] D64968: [Object] Create MutableObject class for doing Object Mutations [Part 2]

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 21:35:01 PDT 2019


abrachet added a comment.

In D64968#1595107 <https://reviews.llvm.org/D64968#1595107>, @MaskRay wrote:

> If you have branches a, b, and c (`a` depends on `master`, `b` depends on `a`, `c` depends on `b`):
>
>   # after syncing master, a, b and c became stale.
>   git rebase --onto master 'a^' a
>     arc diff 'HEAD^'  # create/update a revision based on the diff master..a
>   git rebase --onto a 'b^' b  # this also switches to b
>     arc diff 'HEAD^'  # create/update a revision based on the diff a..b     master..a is not included in the revision.
>   git rebase --onto b 'c^' c  # this also switches to b
>     arc diff 'HEAD^'  # create/update a revision based on the diff b..c
>
>
> Perhaps there is a better way to do things but this is how I handle dependent revisions.
>
> In D64281 <https://reviews.llvm.org/D64281>, I still want to see how you are going to use MutableRange. Do you have a design what the end result will be?


Thanks @MaskRay, thats very helpful I was having a hard time managing this.

I ended up just abandoning this revision for now because D64281 <https://reviews.llvm.org/D64281> has changed so drastically and I wasn't ready for a part 2 to that yet so I didn't want this one to just be dangling here. That revision still uses a data structure called MutableRange, but it has changed a lot. I'll work on trying to improve the performance of batch operations on it in a bit. But I've drastically changed my whole project so I have put that off for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64968/new/

https://reviews.llvm.org/D64968





More information about the llvm-commits mailing list