[PATCH] D62875: [GWP-ASan] Add public-facing documentation [6].

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked 15 inline comments as done.
hctim added inline comments.


================
Comment at: llvm/docs/GwpAsan.rst:121
+
+Currently, the only allocator that supports GWP-ASan is the
+`Scudo Hardened Allocator <https://llvm.org/docs/ScudoHardenedAllocator.html>`_.
----------------
morehouse wrote:
> It's a small difference, but I'd prefer a more positive (think advertising) wording here.
> 
> e.g.,
> 
> "GWP-ASan already ships by default in Scudo, so building with `-fsanitize=scudo` is the quickest and easiest way to try out GWP-ASan.  For other allocators, using GWP-ASan is as easy as..."
I think the "for other allocators..." part is covered above in the "Allocator Support" section, but otherwise SGTM+done.


================
Comment at: llvm/docs/GwpAsan.rst:133
+implementation of configuration that is used by Scudo. Several aspects of
+GWP-ASan can be configured on a per process basis through the following ways:
+
----------------
morehouse wrote:
> I'm confused.  Is this per-allocator or per-process?
Hopefully the rewording adds some clarity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62875/new/

https://reviews.llvm.org/D62875