[PATCH] D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization.

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa marked an inline comment as done.
kerbowa added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:659
+                                                     bool HasSideEffects,
+                                                     Optional<unsigned> Flags) {
   auto MIB =
----------------
arsenm wrote:
> Should default to None.
> 
> I'm not sure if this one should get a flags argument. You can set it on the instruction separately from constructing it
The defaults are in the header.

Isn't it more consistent if you can set the flags when constructing it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64966/new/

https://reviews.llvm.org/D64966