[PATCH] D64819: [UpdateTestChecks][Bug41532] Add handle of basic block names.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 17:57:11 PDT 2019


MaskRay added a comment.

In D64819#1595798 <https://reviews.llvm.org/D64819#1595798>, @Whitney wrote:

> I cannot think of any clean way to identify labels, there are three ways that label can be:
>
> 1. at the start of a basic block.
> 2. follow by "label".
> 3. incoming blocks in phinode.
>
>   @MaskRay Do you feel strong to limit the change only to label? If so, can you give me some guidance on how to do it?


It depends on how other reviewers think about it... If it is suggested keeping the diff minimum is a desired property, you probably have to parse `phi` and `label` constructs..


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64819/new/

https://reviews.llvm.org/D64819





More information about the llvm-commits mailing list