[PATCH] D64544: [DWARF] Add more error handling to debug line parser.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 16:22:59 PDT 2019


JDevlieghere added a comment.

In D64544#1596538 <https://reviews.llvm.org/D64544#1596538>, @dblaikie wrote:

> Generally looks good (optional thoughT: maybe the .test file and the .s file could be merged (so the CHECK lines could sit near the assembly they're checking, would make it easier to eyeball whether the tests are testing the right thing, etc)


I agree with the general idea, but given that this test is checking the same prefixes with two inputs (`debug_line_reserved_length.s` and `debug_line_malformed.s`) I think it would just increate the complexity within the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64544/new/

https://reviews.llvm.org/D64544





More information about the llvm-commits mailing list