[llvm] r366527 - [test] [llvm-objcopy] Fix broken test case

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 15:32:58 PDT 2019


Merged to llvm 9 in r366758.

On Thu, Jul 18, 2019 at 7:30 PM Alex Brachet via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> Author: abrachet
> Date: Thu Jul 18 19:31:21 2019
> New Revision: 366527
>
> URL: http://llvm.org/viewvc/llvm-project?rev=366527&view=rev
> Log:
> [test] [llvm-objcopy] Fix broken test case
>
> Summary: The test case added in D62718 did not work unless the user was root because write bits were not set for the output file. This change uses only permissions with user write (0200) to ensure tests pass regardless of the users permissions.
>
> Reviewers: jhenderson, rupprecht, MaskRay, espindola, alexshap
>
> Reviewed By: MaskRay
>
> Subscribers: emaste, arichardson, jakehehrlich, llvm-commits
>
> Tags: #llvm
>
> Differential Revision: https://reviews.llvm.org/D64302
>
> Modified:
>     llvm/trunk/test/tools/llvm-objcopy/ELF/respect-umask.test
>
> Modified: llvm/trunk/test/tools/llvm-objcopy/ELF/respect-umask.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objcopy/ELF/respect-umask.test?rev=366527&r1=366526&r2=366527&view=diff
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objcopy/ELF/respect-umask.test (original)
> +++ llvm/trunk/test/tools/llvm-objcopy/ELF/respect-umask.test Thu Jul 18 19:31:21 2019
> @@ -9,18 +9,25 @@
>  # RUN: touch %t
>  # RUN: chmod 0755 %t
>  # RUN: ls -l %t | cut -f 1 -d ' ' > %t.0755
> -# RUN: chmod 0500 %t
> -# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0500
> -# RUN: chmod 0555 %t
> -# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0555
> +# RUN: chmod 0600 %t
> +# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0600
> +# RUN: chmod 0655 %t
> +# RUN: ls -l %t | cut -f 1 -d ' ' > %t.0655
>
> -# RUN: rm -f %t; yaml2obj %s -o %t
> +# RUN: yaml2obj %s -o %t
>
>  # RUN: umask 0022
>  # RUN: chmod 0777 %t
> -# RUN: rm -f %t1; llvm-objcopy %t %t1
> -# RUN: ls -l %t1 | cut -f 1 -d ' ' > %t1.perms
> -# RUN: cmp %t1.perms %t.0755
> +# RUN: llvm-objcopy %t %t1
> +# RUN: ls -l %t1 | cut -f 1 -d ' ' | cmp - %t.0755
> +
> +# RUN: umask 0177
> +# RUN: llvm-objcopy %t %t2
> +# RUN: ls -l %t2 | cut -f 1 -d ' ' | cmp - %t.0600
> +
> +# RUN: umask 0122
> +# RUN: llvm-objcopy %t %t3
> +# RUN: ls -l %t3 | cut -f 1 -d ' ' | cmp - %t.0655
>
>  --- !ELF
>  FileHeader:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list