[PATCH] D65117: [llvm-Object] Added public MaxSectionAlignment to MachOUniversal

[Anusha Basana via Phabricator via llvm-commits]

anushabasana created this revision.
anushabasana added reviewers: smeenai, compnerd, alexshap.
anushabasana added a project: LLVM.
Herald added subscribers: llvm-commits, hiraditya.

Changed MAXSECTALIGN to a public MaxSectionAlignment in MachOUniversal

Test Plan:


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65117

Files:
  llvm/include/llvm/Object/MachOUniversal.h
  llvm/lib/Object/MachOUniversal.cpp


Index: llvm/lib/Object/MachOUniversal.cpp
===================================================================
--- llvm/lib/Object/MachOUniversal.cpp
+++ llvm/lib/Object/MachOUniversal.cpp
@@ -155,12 +155,13 @@
         ") extends past the end of the file");
       return;
     }
-#define MAXSECTALIGN 15 /* 2**15 or 0x8000 */
-    if (A.getAlign() > MAXSECTALIGN) {
-      Err = malformedError("align (2^" + Twine(A.getAlign()) + ") too large "
-        "for cputype (" + Twine(A.getCPUType()) + ") cpusubtype (" +
-        Twine(A.getCPUSubType() & ~MachO::CPU_SUBTYPE_MASK) +
-        ") (maximum 2^" + Twine(MAXSECTALIGN) + ")");
+
+    if (A.getAlign() > MaxSectionAlignment) {
+      Err = malformedError("align (2^" + Twine(A.getAlign()) +
+                           ") too large for cputype (" + Twine(A.getCPUType()) +
+                           ") cpusubtype (" +
+                           Twine(A.getCPUSubType() & ~MachO::CPU_SUBTYPE_MASK) +
+                           ") (maximum 2^" + Twine(MaxSectionAlignment) + ")");
       return;
     }
     if(A.getOffset() % (1 << A.getAlign()) != 0){
Index: llvm/include/llvm/Object/MachOUniversal.h
===================================================================
--- llvm/include/llvm/Object/MachOUniversal.h
+++ llvm/include/llvm/Object/MachOUniversal.h
@@ -31,6 +31,8 @@
   uint32_t Magic;
   uint32_t NumberOfObjects;
 public:
+  static constexpr uint32_t MaxSectionAlignment = 15; /* 2**15 or 0x8000 */
+
   class ObjectForArch {
     const MachOUniversalBinary *Parent;
     /// Index of object in the universal binary.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65117.211197.patch
Type: text/x-patch
Size: 1591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190722/16f20549/attachment.bin>