[PATCH] D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 14:37:20 PDT 2019


clayborg updated this revision to Diff 211190.
clayborg added a comment.

Changes:

- switch FileWriter over to use llvm::raw_pwrite_stream to avoid needing to use std::ostream
- Remove error handlings from FileWrite since neither llvm::raw_pwrite_stream nor llvm::raw_ostream has any
- Remove the write unsigned integer function that took a byte size to simplify logic
- Use  SmallString +raw_svector_ostream in places that used to use std::ostringstream


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63828/new/

https://reviews.llvm.org/D63828

Files:
  include/llvm/DebugInfo/GSYM/FileWriter.h
  include/llvm/DebugInfo/GSYM/Range.h
  lib/DebugInfo/GSYM/CMakeLists.txt
  lib/DebugInfo/GSYM/FileWriter.cpp
  lib/DebugInfo/GSYM/Range.cpp
  unittests/DebugInfo/GSYM/GSYMTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63828.211190.patch
Type: text/x-patch
Size: 13473 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190722/8c5153da/attachment.bin>


More information about the llvm-commits mailing list