[PATCH] D65096: Add seek support into llvm::raw_ostream that can be conditionally enabled.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D65096#1596357 <https://reviews.llvm.org/D65096#1596357>, @clayborg wrote:

> In D65096#1596337 <https://reviews.llvm.org/D65096#1596337>, @dblaikie wrote:
>
> > Would raw_pwrite_stream suffice?
>
>
> It actually would as I only need to fixup a few things for FileWriter in GSYM. Keeping this patch does allow us to use raw_ostream more file a seekable file, where the pwrite forces you to just do minimal fixups here and there. I am fine abandoning this if no one else thinks it is useful. Comments?


I think if we want more seekable file API - might be more suitable to expand/rename raw_pwrite_stream - so the seekability is part of the static type rather than a dynamically queried property, etc.

(but yeah, doesn't seem like a super high priority for this extra functionality)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65096/new/

https://reviews.llvm.org/D65096