[PATCH] D65079: [GlobalISel][AArch64] Fix narrowScalar for G_ICMP

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 13:28:06 PDT 2019


brzycki added subscribers: SjoerdMeijer, evandro, rengolin, t.p.northover.
brzycki added a comment.

Hello @Petar.Avramovic , I have verified this patch on a recent sha 510e6fadaae95a41bee0eb99d84a146efc612365 <https://reviews.llvm.org/rG510e6fadaae95a41bee0eb99d84a146efc612365> does not crash clang when compiling the libcxx shared library. Thank you for identifying the source of the crash.

I don't feel comfortable enough reviewing this change for all Aarch64 targets and recommend @evandro , @SjoerdMeijer, @rengolin, and/or @t.p.northover examine the change to `lib/Target/AArch64/AArch64LegalizerInfo.cpp` and its potential implications.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65079/new/

https://reviews.llvm.org/D65079





More information about the llvm-commits mailing list