[PATCH] D65081: AMDGPU: Start redefining atomic PatFrags

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 10:46:00 PDT 2019


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM, but please add more comment about cmpswap before sumbitting.



================
Comment at: lib/Target/AMDGPU/AMDGPUInstructions.td:572
 
-def atomic_cmp_swap_local : AtomicCmpSwapLocal <atomic_cmp_swap>;
+// FIXME
+def atomic_cmp_swap_local_32 : AtomicCmpSwapLocal <atomic_cmp_swap>;
----------------
You need to add a little bit more of a comment here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65081/new/

https://reviews.llvm.org/D65081





More information about the llvm-commits mailing list