[PATCH] D65016: Changes to emit CodeView debug info nested type records properly using MCStreamer directives

NILANJANA BASU via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 10:45:34 PDT 2019


nilanjana_basu marked 4 inline comments as done.
nilanjana_basu added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeRecordMapping.cpp:403
+  if (IO.isStreaming()) {
+    if (auto EC = codeview::visitMemberRecordStream(Record.Data, *this))
+      return EC;
----------------
rnk wrote:
> Oh, it's much easier than it seems, I guess. :)
Yes, it ended up being pretty easy. visitMemberRecordStream() passes the TypeRecordMapping instance to create a pipeline along with the deserializer. For now, the deserializer gets executed twice (once with TypeRecordMapping & once with TypeDumpVisitor) till TypeDumpVisitor is removed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65016/new/

https://reviews.llvm.org/D65016





More information about the llvm-commits mailing list