[PATCH] D65060: [LICM] Make Loop ICM profile aware

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

Thank you for the patch. This LGTM.



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:885
+              CurLoop->getLoopPreheader()->getTerminator()) &&
+          worthSinkOrHoistInst(I, CurLoop->getLoopPreheader(), ORE, BFI)) {
         hoist(I, DT, CurLoop, CFH.getOrCreateHoistedBlock(BB), SafetyInfo,
----------------
Nit: It may be worth checking worthSinkOrHoistInst prior to some of the other conditions if it's a faster/cheaper shortcutting condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65060/new/

https://reviews.llvm.org/D65060