[PATCH] D64281: [Object] Create MutableObject class for doing Object Mutations [Part 1]

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Couple more nits. My comment about the description etc not being updated STILL hasn't been addressed though. Please do so.



================
Comment at: llvm/include/llvm/Object/MutableELFObject.h:47
+
+  using MappingType =
+      typename MutableRange<MutableELFSection<ELFT>>::MappingType;
----------------
Do you anticipate this being used in other future functions within this class? If not, move it inside the function, to reduce its effect to where it's actually used.


================
Comment at: llvm/include/llvm/Object/MutableObject.h:47
+        [&Extract](typename Iter::value_type Value) -> MappingType {
+          auto Extracted = Extract(Value);
+          assert(Extracted <= (UINT64_MAX >> 1) && "returned type too large");
----------------
Another instance of too much auto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64281/new/

https://reviews.llvm.org/D64281