[PATCH] D64913: [yaml2obj] - Add a support for defining null sections in YAMLs.

Mon Jul 22 09:39:59 PDT 2019

jhenderson added inline comments.

================
Comment at: test/tools/yaml2obj/elf-custom-null-section.yaml:48
+# RUN: yaml2obj --docnum=3 %s -o %t3
+# RUN: llvm-readelf --sections %t3 | FileCheck %s --check-prefix=ZERO-VS-NONZERO
+
----------------
I don't like "ZERO-VS-NONZERO" here, because it's not really anything to do with that. This test case is for testing that other sections can be added after the NULL section. "ZERO-VS-NONZERO" doesn't clarify that. How about "OTHER-SECTION"?

================
Comment at: test/tools/yaml2obj/elf-custom-null-section.yaml:71
+    EntSize:      0x0
+    Link:         ""
+  - Type: SHT_PROGBITS
----------------
Nit: Link: 0 (be consistent with above change).

================
Comment at: test/tools/yaml2obj/elf-custom-null-section.yaml:145
+
+## Check we do not crash if have more than one SHT_NULL section.
+
----------------
if we have

================
Comment at: test/tools/yaml2obj/elf-custom-null-section.yaml:162-163
+Sections:
+  - Type: SHT_NULL
+  - Type: SHT_NULL
----------------
Perhaps worth setting some fields to different explicit values, to show that it's possible.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64913/new/

https://reviews.llvm.org/D64913