[PATCH] D65093: [llvm-ar] Fix support for archives with members larger than 4GB

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added inline comments.


================
Comment at: include/llvm/Object/Archive.h:224
+  /// Size field is 10 decimal digits long
+  static const uint64_t MaxMemberSize = 9999999999;
+
----------------
MaskRay wrote:
> I am curious why you want to handle a file whose size is within [4294967296,9999999999] (4G is a bit unusual as a binary. But you don't allow it to be larger..).
In the past we have had a user that required support for members larger 4gb, and when experimenting with gnu-ar on my Ubuntu machine, it supports members over that size.

The maximum size value `9999999999` is a limit of the file format itself. The file size in bytes is stored as a 10 digit decimal integer, meaning `MaxMemberSize` is the largest member size the format supports.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65093/new/

https://reviews.llvm.org/D65093