[PATCH] D64902: [InstSimplify] Rename SimplifyFPUnOp and SimplifyFPBinOp

[Jay Foad via Phabricator via llvm-commits]

foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:59
                             unsigned);
-static Value *SimplifyFPBinOp(unsigned, Value *, Value *, const FastMathFlags &,
-                              const SimplifyQuery &, unsigned);
+static Value *SimplifyBinOp(unsigned, Value *, Value *, const FastMathFlags &,
+                            const SimplifyQuery &, unsigned);
----------------
xbolva00 wrote:
> @spatel suggested to make FastMastFlags as last optional argument
Actually I suggested that (in D64713) and @spatel "ok"ed it. But when I came to make the change, I felt that the FastMathFlags argument belonged next to the LHS and RHS arguments. Do you care deeply about the order?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64902/new/

https://reviews.llvm.org/D64902