[PATCH] D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 22 02:38:29 PDT 2019


nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1332
+      // Waterfall loop for m0 value, which is always the last operand.
+      executeInWaterfallLoop(MI, MRI, { MI.getNumOperands() - 1 });
+      return;
----------------
We don't waterfall these in the non-GlobalISel path as far as I can tell? Should just use readfirstlane if necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64862/new/

https://reviews.llvm.org/D64862





More information about the llvm-commits mailing list