[PATCH] D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D64800#1593760 <https://reviews.llvm.org/D64800#1593760>, @sbc100 wrote:

> Is there a danger that by moving in this direction we loose some test coverage since we are no longer verifying the libObject can read a know set of binaries, but only that libObject can read the output yaml2obj?   i.e. we could evolve the object format in llvm such that these tests would continue pass but the objects would no longer be standards compliant?


I think the pre-canned binaries don't really help us any more than yaml2obj inputs - it would be just as straightforward to tune our object reading code to work with a very specific set of binaries (unintentionally or otherwise) as it would be to work with our yaml2obj output. It's worth noting that the yaml2obj writing code and llvm-readobj reading code are not the same set of code, so we are already testing two different implementations against each other. If we change one and not the other, a test should break, alerting us to a behaviour change. We would need a good reason to change both.

Basically, I don't think we need to be concerned.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64800/new/

https://reviews.llvm.org/D64800