[PATCH] D64999: [yaml2obj] - Change how we handle implicit sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: include/llvm/ObjectYAML/ELFYAML.h:155
+
+  Section(SectionKind Kind, bool IsImplicit)
+      : Kind(Kind), IsImplicit(IsImplicit) {}
----------------
Perhaps worth considering making `IsImplicit` a default argument?


================
Comment at: tools/yaml2obj/yaml2elf.cpp:195
+
+  std::vector<StringRef> ImplicitSections = {".symtab", ".strtab", ".shstrtab"};
+  if (!Doc.DynamicSymbols.empty())
----------------
Just a thought, not really related to this change, but shouldn't the presence of .symtab and .strtab be dependent on there being any symbols defined (just like .dynsym/.dynstr)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64999/new/

https://reviews.llvm.org/D64999