[PATCH] D64819: [UpdateTestChecks][Bug41532] Add handle of basic block names.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:139
 # spaces, commas, paren, or end of the string
-IR_VALUE_RE = re.compile(r'(\s+)%([\w\.\-]+?)([,\s\(\)]|\Z)')
+IR_VALUE_RE = re.compile(r'(\s+%)([\w\.\-]+?)([,\s\(\)]|\Z)')
+
----------------
I'm concerned that the `%` change will create a huge amount of diff.

Can you make the updated form only apply to labels?


================
Comment at: llvm/utils/UpdateTestChecks/common.py:142
+# Match things that end with colon
+IR_LABEL_RE = re.compile(r'()(^.+)(:$)')
 
----------------
`IR_LABEL_RE = re.compile(r'^()([-\w\.]+)(:)$')`



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64819/new/

https://reviews.llvm.org/D64819