[PATCH] D64973: [MustExec][NFC] Expose a common LoopSafetyInfo interface
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 21 13:50:11 PDT 2019
lebedev.ri added inline comments.
================
Comment at: llvm/include/llvm/Analysis/MustExecute.h:73
+ virtual void insertInstructionAfter(const Instruction *NewI,
+ const Instruction *PosI){};
+
----------------
jdoerfert wrote:
> jdoerfert wrote:
> > lebedev.ri wrote:
> > > `const Instruction *PosI) {}`
> > I'll clang-format, I though I did already.
> I could probably make them pure as well.
I'm mainly commenting on that extra `;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64973/new/
https://reviews.llvm.org/D64973
More information about the llvm-commits
mailing list