[PATCH] D65047: [DAGCombine] matchBinOpReduction - add partial reduction matching

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 21 07:52:48 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:9086-9087
 
   BinOp = (ISD::NodeType)CandidateBinOp;
   return Op;
 }
----------------
lebedev.ri wrote:
> Would it be better to always return via `PartialReduction()`, and special-case the case with non-partial reduction in `PartialReduction()` itself?
I don't think so - it gains us nothing and just complicates the logic in PartialReduction()


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65047/new/

https://reviews.llvm.org/D65047





More information about the llvm-commits mailing list