[PATCH] D65048: [GISel]: Attach missing range metadata while translating G_LOADs

Sun Jul 21 07:23:41 PDT 2019

arsenm added a comment.

In D65048#1594810 <https://reviews.llvm.org/D65048#1594810>, @aditya_nandakumar wrote:

> In D65048#1594784 <https://reviews.llvm.org/D65048#1594784>, @arsenm wrote:
>
> > LGTM. Are you planning on adding a MI computeKnownBits to use this? I will soon have a need for one and don't want to repeat work
>
>
> Yes - that's how I stumbled on this.
>  We have an out of tree port of most of DAG's ComputeKnownBits and SimplifyDemandedBits already implemented. It hasn't been upstreamed yet because
>
> 1. There was no need until now.
> 2. Writing tests were/are pain and are dependent on combines which upstream didn't have a lot of.
>
>   I'd be happy to create a patch for that assuming we decide to go down the route of a direct port of DAG like implementation.

I don't know what could be significantly different

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65048/new/

https://reviews.llvm.org/D65048