[PATCH] D28855: [CMake] Copy per-component `required_libraries` into `LINK_COMPONENTS`. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 20 07:55:17 PDT 2019


sbc100 added inline comments.


================
Comment at: llvm/utils/llvm-build/llvmlinkcomps.py:1
+from llvmbuild.main import LLVMProjectInfo
+from os import pardir, path
----------------
Start script with `#!/usr/bin/env python`

Add  `from __future__ import print_function`?

Add a file-level docstring to say what this does?  When is this script supposed to run and by whom?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28855/new/

https://reviews.llvm.org/D28855





More information about the llvm-commits mailing list