[PATCH] D65048: [GISel]: Attach missing range metadata while translating G_LOADs
Aditya Nandakumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 21 06:16:55 PDT 2019
aditya_nandakumar marked an inline comment as done.
aditya_nandakumar added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:892
Ptr, Flags, (MRI->getType(Regs[i]).getSizeInBits() + 7) / 8,
- MinAlign(BaseAlign, Offsets[i] / 8), AAMDNodes(), nullptr,
+ MinAlign(BaseAlign, Offsets[i] / 8), AAMDNodes(), Ranges,
LI.getSyncScopeID(), LI.getOrdering());
----------------
arsenm wrote:
> How does this work if it's split into multiple register? I would assume this needs to be decomposed and only trivially valid if there is one result register
Good point. I didn't think of that. For now I'll add the ranges only if there is one register.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65048/new/
https://reviews.llvm.org/D65048
More information about the llvm-commits
mailing list