[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM
Jian Cai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 20 23:39:05 PDT 2019
jcai19 added a comment.
In D65019#1594289 <https://reviews.llvm.org/D65019#1594289>, @efriedma wrote:
> I don't like introducing magic calling convention rules for a non-intrinsic function with a specific name; we should model this more explicitly somehow. Probably the simplest thing to do would be to introduce an ARM intrinsic, lower it to a pseudo-instruction, and expand it late (in ExpandPostRAPseudos or something like that).
Thanks for the suggestions, will start work on it.. I also realized this solution may have other issues that @t.p.northover kindly pointed out in another code review that I accidentally creates (https://reviews.llvm.org/D65037) for the same change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65019/new/
https://reviews.llvm.org/D65019
More information about the llvm-commits
mailing list