[PATCH] D64871: [llvm-lipo] Implement alignment function in -create

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/lib/Object/MachOUniversal.cpp:164
+                           Twine(A.getCPUSubType() & ~MachO::CPU_SUBTYPE_MASK) +
+                           ") (maximum 2^" + Twine(MaxSectionAlignment) + ")");
       return;
----------------
Personally, I would have split the changes in this file and in `MachOUniversal.h` into a separate change.  That change is a very simple change that could probably merged immediately.


================
Comment at: llvm/test/tools/llvm-lipo/Inputs/CPU10-slice.yaml:1
+--- !mach-o
+FileHeader:      
----------------
CPU10 is not particularly helpful.  Would be nice to use the human readable form (m88k).


================
Comment at: llvm/test/tools/llvm-lipo/Inputs/CPU14-slice.yaml:1
+--- !mach-o
+FileHeader:
----------------
Similar for the file name


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:350
+// For compatibility with cctools lipo, alignment is calculated as the minimum
+// aligment of all load commands. Each load command's alignment is the maximum
+// alignment from its sections
----------------
ITYM segment instead of all load commands.  The alignment of something like `LC_REEXPORT_DYLIB` seems irrelevant to this or am I mistaken on that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64871/new/

https://reviews.llvm.org/D64871