[PATCH] D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention

Ryan Taylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 20 10:36:44 PDT 2019


rtaylor marked an inline comment as done.
rtaylor added inline comments.


================
Comment at: lib/CodeGen/CallingConvLower.cpp:94
     if (Fn(i, ArgVT, ArgVT, CCValAssign::Full, ArgFlags, *this)) {
-#ifndef NDEBUG
-      dbgs() << "Formal argument #" << i << " has unhandled type "
-             << EVT(ArgVT).getEVTString() << '\n';
-#endif
-      llvm_unreachable(nullptr);
+      report_fatal_error("unable to allocate register");
     }
----------------
arsenm wrote:
> s/register/function argument/
Yes, I realized that last night after I submitted but had to run. I also thought it would be useful info to put which argument/return index was causing the issue.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64933/new/

https://reviews.llvm.org/D64933





More information about the llvm-commits mailing list