[PATCH] D56772: [MIR] Add simple PRE pass to MachineCSE

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 20 08:08:36 PDT 2019


lkail added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/MachineCSE.cpp:807
+      if (BB != nullptr && BB1 != nullptr &&
+          (isPotentiallyReachable(BB1, BB) ||
+           isPotentiallyReachable(BB, BB1))) {
----------------
Hi @anton-afanasyev , I have a concern here that CFG of LLVM IR might not be equivalent to CFG of Machine IR.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56772/new/

https://reviews.llvm.org/D56772





More information about the llvm-commits mailing list